Changeset c4f89cf

Timestamp:

05/28/15 17:09:31 (9 years ago)

Author:

Hal Finkel <hfinkel@…>

Branches:

master

Children:

6520ef5

Parents:

4bd7a88

git-author:

Hal Finkel <hfinkel@…> (05/28/15 17:09:31)

git-committer:

Hal Finkel <hfinkel@…> (05/28/15 17:09:31)

Message:

common nodes correctly

File:

• memlog2dot (modified) (5 diffs)

memlog2dot

@@ -5 +5 @@
 my $total_size = 0;
 my %roots;
-my @all_nodes;
+my %all_nodes;
 foreach my $line ( <STDIN> ) {
   chomp($line);
@@ -46 +46 @@
     # print STDERR "parsed: $file_name, $proc_name, $off, $pc, $relpc\n";
 
+    if (!exists $all_nodes{$pc}) {
+      $all_nodes{$pc}->{'file_name'} = $file_name;
+      $all_nodes{$pc}->{'proc_name'} = $proc_name;
+      $all_nodes{$pc}->{'off'} = $off;
+      $all_nodes{$pc}->{'pc'} = $pc;
+      $all_nodes{$pc}->{'relpc'} = $relpc;
+    }
+
     if (!exists $parent->{$pc}) {
-      $parent->{$pc}->{'file_name'} = $file_name;
-      $parent->{$pc}->{'proc_name'} = $proc_name;
-      $parent->{$pc}->{'off'} = $off;
-      $parent->{$pc}->{'pc'} = $pc;
-      $parent->{$pc}->{'relpc'} = $relpc;
-
-      push(@all_nodes, $parent->{$pc});
+      $parent->{$pc} = $all_nodes{$pc};
     }
 
@@ -141 +143 @@
 my %skipped;
 
-foreach my $node (@all_nodes) {
+foreach my $pc (keys %all_nodes) {
+  my $node = $all_nodes{$pc};
   my $name = get_name($node);
 
   my $local_size = $node->{'size'};
   if ($local_size * 1.0 / $total_size < $skip_frac) {
-    $skipped{$node->{'pc'}} = 1;
+    $skipped{$pc} = 1;
     next;
   }
@@ -156 +159 @@
 
   printf("N%s [label=\"%s\\n%s\", shape=box,fontsize=%.1f%s];\n",
-    $node->{'pc'}, $name, format_bytes($local_size), $fs);
+    $pc, $name, format_bytes($local_size), $fs);
 }
 
-foreach my $node (@all_nodes) {
+foreach my $pc (keys %all_nodes) {
+  my $node = $all_nodes{$pc};
+
   my $local_size = $node->{'size'};
-  if ($skipped{$node->{'pc'}}) {
+  if ($skipped{$pc}) {
     next;
   }
@@ -177 +182 @@
 
     printf("N%s -> N%s [label=\"%s\", weight=%d, style=\"%s\"];\n",
-      $node->{'pc'}, $cpc, format_bytes($child_size), $weight, $style);
+      $pc, $cpc, format_bytes($child_size), $weight, $style);
   }
 }